Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to import theme items from the edit panel #3876

Open
KoBeWi opened this issue Jan 27, 2022 · 3 comments
Open

Allow to import theme items from the edit panel #3876

KoBeWi opened this issue Jan 27, 2022 · 3 comments

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Jan 27, 2022

Describe the project you are working on

A game with lots of UI

Describe the problem or limitation you are having in your project

I've been making a custom theme and came across some icons from default theme that are too small. I wanted to save them as separate file and make bigger, but it's not easy to do.

The icon is right here, but when I click the + button it disappears:
godot windows opt tools 64_zg1bdeqvVL
Which means that I have to go to the import menu and import it manually.

Describe the feature / enhancement and how it helps to overcome the problem or limitation

Allow to fetch the default value instead of clearing it.

Describe how your proposal will work, with code, pseudo-code, mock-ups, and/or diagrams

Maybe add another button besides the + icon that will quick-import the value, so you can edit it.

If this enhancement will not be used often, can it be worked around with a few lines of script?

Not really, it would require editor hacking.

Is there a reason why this should be core and not an add-on in the asset library?

It's about theme editor usability.

@Zireael07
Copy link

Fetching default value instead of clearing would also be useful for editor font settings, I imagine.

@YuriSizov
Copy link
Contributor

There is a bit of inconsistency there, I admit. Primitive types are copied, but not resources. I wasn't sure which kind of behavior would be preferable so I went with what was working before in the old theme editor.

When @YeldhamDev was adding UndoRedo, he at first made it so that resources are also copied when you override, but that led to some issues, so I think he reverted it to fix them. So there is that. But I'm not against the idea.

@YeldhamDev
Copy link
Member

If I remember correctly, the main reason that I reverted that was because it wasn't how the theme editor behaved originally. I wanted to add the undo/redo system without changing how the editor worked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants