Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update designs for text-heavy pages #416

Merged
merged 1 commit into from Aug 3, 2022
Merged

Update designs for text-heavy pages #416

merged 1 commit into from Aug 3, 2022

Conversation

bits-by-brandon
Copy link
Contributor

Tightens up the layout and styles of the text heavy about/* pages

Makes the following changes:

  • creates new .container-text style to constrain text to a readable max-width
  • creates subtle borders around table rows
  • removes colons on table headers
  • creates better header spacing for long text

Screen Shot 2022-07-22 at 11 09 08 AM

Screen Shot 2022-07-22 at 11 09 21 AM

Screen Shot 2022-07-22 at 11 09 00 AM

@bits-by-brandon bits-by-brandon force-pushed the brandonchang/text-heavy-page-typography branch from ea488f4 to 43e3272 Compare July 22, 2022 15:17
@bits-by-brandon bits-by-brandon force-pushed the brandonchang/text-heavy-page-typography branch 3 times, most recently from b114c7a to cfbe876 Compare July 22, 2022 15:36
@Calinou Calinou added the topic:theme Issues and PRs related to styling and scripts of the frontend label Jul 22, 2022
@YuriSizov YuriSizov changed the title Brandonchang/text heavy page typography Update designs for text-heavy pages Jul 27, 2022
@bits-by-brandon bits-by-brandon force-pushed the brandonchang/text-heavy-page-typography branch from cfbe876 to 3c5dd74 Compare July 29, 2022 02:43
@bits-by-brandon
Copy link
Contributor Author

@Calinou Any revisions needed, or can this get merged?

Calinou
Calinou approved these changes Aug 3, 2022
View reviewed changes
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!

@Calinou Calinou merged commit 82e841a into godotengine:master Aug 3, 2022
@Calinou
Copy link
Member

Calinou commented Aug 3, 2022 •
edited

I noticed that the text is offset to the right on mobile. Can you look into this?

image

@bits-by-brandon
Copy link
Contributor Author

Yeah I'll take a look later today

@bits-by-brandon bits-by-brandon mentioned this pull request Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

@YuriSizov YuriSizov Awaiting requested review from YuriSizov

Assignees
No one assigned
Labels
enhancement topic:theme Issues and PRs related to styling and scripts of the frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bits-by-brandon @Calinou @YuriSizov