Skip to content

Commit

Permalink
Fix bad parameter of rendering_method crashes Godot
Browse files Browse the repository at this point in the history
Print error and default to forward plus
  • Loading branch information
jsjtxietian committed Oct 31, 2023
1 parent 9144457 commit 08e36dc
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions servers/rendering/renderer_rd/renderer_compositor_rd.cpp
Expand Up @@ -315,10 +315,11 @@ RendererCompositorRD::RendererCompositorRD() {
WARN_PRINT_ONCE("Platform supports less than 48 textures per stage which is less than required by the Clustered renderer. Defaulting to Mobile renderer.");
}
} else if (rendering_method == "forward_plus") {
// default to our high end renderer
scene = memnew(RendererSceneRenderImplementation::RenderForwardClustered());
} else {
ERR_FAIL_MSG("Cannot instantiate RenderingDevice-based renderer with renderer type " + rendering_method);
// Fall back to our high end renderer
ERR_PRINT(vformat("Cannot instantiate RenderingDevice-based renderer with renderer type '%s'. Defaulting to Forward+ renderer.", rendering_method));
scene = memnew(RendererSceneRenderImplementation::RenderForwardClustered());
}

scene->init();
Expand Down

0 comments on commit 08e36dc

Please sign in to comment.