Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening a folder with .cs files crashes Godot (Mono related?) #11834

Closed
NathanWarden opened this issue Oct 4, 2017 · 7 comments
Closed

Opening a folder with .cs files crashes Godot (Mono related?) #11834

NathanWarden opened this issue Oct 4, 2017 · 7 comments
Assignees
Milestone

Comments

@NathanWarden
Copy link
Contributor

NathanWarden commented Oct 4, 2017

Godot 3.0 git HEAD 64 bit

Manjaro Linux 64 bit
Ubuntu 17.10b2
Windows 10

Issue description:

When navigating into a CSharp scripts folder Godot crashes if there's a .mono folder and if there are no icons of the scripts in the ~/.godot/tmp folder.

@neikeq I believe this is Mono related as a lot of Mono items are in the crash log, deleting the .mono folder fixes the crash, or if I simply rename files from having .cs to .gd (and leave the .mono folder there) it no longer crashes.

Steps to reproduce:

edit: Okay, I've narrowed it down a bit more. I tried it on Ubuntu 17.10b2 and I was able to navigate to the folder as long as I didn't first make a build.

I was then able to cause it to break again by:

  1. Deleting the ~/.godot/tmp folder
  2. Make a build (F5/F6)
  3. Restart the editor
  4. Navigate to the Scripts folder
    Crash

I was able to navigate again to the folder by:

  1. Deleting the .mono folder for the project
  2. Restart the editor
  3. Navigate to the folder
    No crash

So, it seems somehow related to failing to generate icons when there's a successful build in the .mono folder?

I've made a video: DirectoryOpenCrash.zip

Link to minimal example project:

edit: Here's a simple project:

Test_Proj_CS.zip

edit: Removed the crash dump as you should now be able to get your own now that the bug is reproducible.

@ghost ghost added this to the 3.0 milestone Oct 4, 2017
@NathanWarden
Copy link
Contributor Author

NathanWarden commented Oct 4, 2017

edit: I've moved the steps here to the top...

Okay, I've narrowed it down a bit more. I tried it on Ubuntu 17.10b2 and I was able to navigate to the folder as long as I didn't first make a build.

I was then able to cause it to break again by:

  1. Deleting the ~/.godot/tmp folder
  2. Make a build (F5/F6)
  3. Restart the editor
  4. Navigate to the Scripts folder
    Crash

I was able to navigate again to the folder by:

  1. Deleting the .mono folder for the project
  2. Restart the editor
  3. Navigate to the folder
    No crash

So, it seems somehow related to failing to generate icons when there's a successful build in the .mono folder?

Okay, time to try it on Windows again since I didn't try these steps before.

@NathanWarden
Copy link
Contributor Author

Yep, happens on Windows too.

@NathanWarden
Copy link
Contributor Author

Okay, I was able to reproduce the problem with the steps above in a simple project. :)

Test_Proj_CS.zip

@neikeq neikeq self-assigned this Oct 4, 2017
@neikeq
Copy link
Contributor

neikeq commented Oct 5, 2017

Does this still happen after #11845?

@NathanWarden
Copy link
Contributor Author

Unfortunately it's still doing it.

@neikeq
Copy link
Contributor

neikeq commented Oct 5, 2017

All right, just wanted to make sure it was not related to the assembly loading error at startup. I'll test tomorrow.

@NathanWarden
Copy link
Contributor Author

Awesome, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants