Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find in Files/Replace in Files #16336

Closed
vonflyhighace2 opened this issue Feb 2, 2018 · 7 comments · Fixed by #16571
Closed

Find in Files/Replace in Files #16336

vonflyhighace2 opened this issue Feb 2, 2018 · 7 comments · Fixed by #16571

Comments

@vonflyhighace2
Copy link

vonflyhighace2 commented Feb 2, 2018

Godot version:
Any

OS/device including version:
Any/Engine Level

Issue description:
there is a find/replace in file but this should be expanded to files throughout the project to include more search capabilities. Also can we have button Icons not be fixed sizes, I seen no reason for this. there is no way to adjust the rect of a button fitted with a texture in the Icon property.

Steps to reproduce:
This would be a tremendous feature since a lot of people use external code editors solely for mass refactoring, plus just a nice feature in general.

Minimal reproduction project:

@vnen
Copy link
Member

vnen commented Feb 3, 2018

Related to #2592.

@vonflyhighace2
Copy link
Author

Wow from 2 years ago talk about being buried.

@vnen
Copy link
Member

vnen commented Feb 3, 2018

It's not much about being buried, it's more about no one caring enough to actually make it happen.

@NathanWarden
Copy link
Contributor

You might as well comment on it if you're interested in it... or if you know how to it would be awesome if you could go ahead and implement it :)

@Ranoller
Copy link
Contributor

Ranoller commented Feb 4, 2018

I have a modification of TODO plugin that do that (only search, not replace) but godot 2 do not expose to gdscript enought methods to scroll to any line in the script, so you only see where are the search result and the line, and you need to scroll to that manually. TODO plugin it's not ported to godot 3... I suscribe this feature request with all my heart. Perfect example of this feature is the way that is implemented in notepad++(find in open files, replace in open files, with a contextual window with the search results that allow to jump to file and line).... But i'm realist about that, this is not trivial, i'm happy with code folding and function list, this is "the third" of the trinity of the text-editor features in my opinion...

@Zylann
Copy link
Contributor

Zylann commented Feb 8, 2018

I started such a tool this evening :p
But I agree with @Ranoller , the lack of EditorPlugin functions to interact with the script editor prevents part of the prototyping.

@pingudroid
Copy link

I was going to post the same suggestion! I'd really like being able to mass-search and mass-replace across all project scripts.

Another example of a program that does this well is Bluefish, which is the one I've been using. But it would be much better to be able to do all script-related stuff directly inside of Godot.

Here's an idea to polish it further: being able to choose between searching in all files in the project, searching in open files or just in files in a particular folder. But just a basic option that includes all files would be really nice already.

Btw, thanks for your work, guys! :) This engine is awesome. I hope I can contribute some day.

@akien-mga akien-mga changed the title Feature Request. Find in Files/Replace in Files Find in Files/Replace in Files Feb 13, 2018
@akien-mga akien-mga added this to the 3.1 milestone Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants