glTF default roughnessFactor should be 1 #19613
Labels
Milestone
Comments
bkmeneguello
changed the title
|
I didn't compare the other attributes with the spec, only found this by accident. |
|
Maybe related to #10160 Not sure as this is more specific to the gltf importer |
|
@Keetz, I think it's not related. I noticed the glTF importer is leaving the roughness value of material with the default value when it's not set on ".gltf" file. But glTF spec says the default value should be 1, while Godot's default value is 0. It means Godot's glTF importer must force roughness to 1 when the file omits its value. I'm not suggesting to change the Godot's default material roughness value. |
|
I can assure that metallic factor should default to 1 too, but it is wrongly 0 by default after import. |
rodolforg
added a commit
to rodolforg/godot
that referenced
this issue
Jun 21, 2018
The glTF 2.0 spec says that these pbrMetallicRoughness material properties should be set as 1.0 by default. In fact, KhronosGroup's official Blender Exporter does not even write down those parameters if they are set as 1.0. However, Godot import them as 0.0. https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#pbrmetallicroughness Fixes: godotengine#19613 godotengine#19613
hpvb
pushed a commit
that referenced
this issue
Jul 10, 2018
The glTF 2.0 spec says that these pbrMetallicRoughness material properties should be set as 1.0 by default. In fact, KhronosGroup's official Blender Exporter does not even write down those parameters if they are set as 1.0. However, Godot import them as 0.0. https://github.com/KhronosGroup/glTF/tree/master/specification/2.0#pbrmetallicroughness Fixes: #19613 #19613 (cherry picked from commit 01b0120)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Accordingly to glTF specification, default
roughnessFactorshould be 1, but currently, it's not being set, so, it defaults to 0.The text was updated successfully, but these errors were encountered: