bad polygon! error when changing TextureProgress value from 0 to 1

[ghost]

latest master. compiled last night.

in any event. this bug is pretty weird. took me a while to track it down

steps:

• create TextureProgress
• give it texture progress texture
• create a tween in the scene
• attach gdscript file

put in gdscript:

tween.interpolate_property(texture_progress, "value", 100, 0,  2, 0, 0)
tween.start()

and look at the error:

full error:

godot/servers/visual/visual_server_canvas.cpp

Line 692 in cf834a2

ERR_FAIL_V();

0:00:04:0775 - Bad Polygon!
----------
Type:Error
Description: Bad Polygon!
Time: 0:00:04:0775
C Error: Method/Function Failed, returning: 
C Source: servers\visual\visual_server_canvas.cpp:692
C Function: VisualServerCanvas::canvas_item_add_polygon

[ghost]

this could also be related to why the tween does not TWEEN in a linear fashion, which is related to my other issue #21818

[Piet-G]

I'm not getting the bad polygon error. Do you have a reproduction project?

[ghost]

@dualmatrix going to make one right now. sorry just saw this

[ghost]

@dualmatrix badpolygonerror.zip
click anywhere on screen. look at how it behaves (not linear and at the end it like glitches out lol), and you get bad polygon error. this code works flawlessly in 3.0.6. might be regression somewhere. ty for taking a look.

E 0:00:03:0248   Bad Polygon!
  <C Source>     servers\visual\visual_server_canvas.cpp:692 @ VisualServerCanvas::canvas_item_add_polygon()

[Piet-G]

Ah this seems to be a problem with TextureProgress breaking with values between 0 and 1

[ghost]

@dualmatrix ha, nice catch. yep. sorry i just kept thinking it was related to tweening lol (cause was using that as my hotkey bar spinner in game)

e: changed the title, thanks!

[Piet-G]

This seems to happen because you had exp_edit enabled in the TextureProgress

[Piet-G]

Apparently when exp_edit is true then min_value must be > 0

[tom-jk]

Testing MRP:
Can reproduce "bad polygon!" error in 3.1.stable.
Can't reproduce "bad polygon!" error in 3.2.stable, 3.2.2.stable, 3.2.3.beta1.

There remains the configuration warning in the scene tree about how min_value must be greater than zero when exp_edit is enabled, but there's no longer any apparent consequence for doing so (you can also go negative). Is it obsoleted?

edit: I notice it does make a difference for other controls, eg. hslider. So the warning is still relevant.