Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added warning when min_value of range <= 0 while exp_edit is true. #22381

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Added warning when min_value of range <= 0 while exp_edit is true. #22381

merged 1 commit into from
Sep 28, 2018

Conversation

Piet-G
Copy link
Contributor

@Piet-G Piet-G commented Sep 23, 2018

Added warning when min_value of range is smaller or equal to 0 while exp_edit is true.
The new warning is: "If exp_edit is true min_value must be > 0."

This should make it more clear, see #21923

…t is true.

Added warning when min_value of range is smaller than 0 while exp_edit is true.

The new warning is: "If exp_edit is true min_value must be > 0."
@ghost
Copy link

ghost commented Sep 23, 2018

@dualmatrix i think there is something else going on here.
because, I just tested the example in 3.0.6.
the value performs perfectly fine if it goes to 0, even when exp_edit is enabled. i believe something was changed from 3.0.6 to 3.1 (the root issue)

@Piet-G
Copy link
Contributor Author

Piet-G commented Sep 23, 2018

@girng I'm just going by the docs which state that the value must be > 0

@ghost
Copy link

ghost commented Sep 23, 2018

the docs say the min_value must be greater than 0. the value is bugged if it's set to 0, when exp_edit is enabled in 3.1. that's not the case in 3.0.6

@Piet-G
Copy link
Contributor Author

Piet-G commented Sep 23, 2018

@girng The bug with value only occurs when min_value is <= 0 and exp_edit is true otherwise it works fine.

@Piet-G
Copy link
Contributor Author

Piet-G commented Sep 23, 2018

I took a look at the 3.0 code and previously exp_edit was just ignored if min_val <= 0.
I'm not sure which behavior is preferred. Displaying a warning seems more logical to me.

@ghost
Copy link

ghost commented Sep 23, 2018

@girng The bug with value only occurs when min_value is <= 0 and exp_edit is true otherwise it works fine.

That's what I thought was normal (not a bug)... okay, well a lot of game projects who will move from 3.0.6 to 3.1 will most likely need to adjust this then :P

but yeah,i agree, a warning would be best. instead of this bad polygon! stuff that i got lolz

@Piet-G
Copy link
Contributor Author

Piet-G commented Sep 23, 2018

@girng exp_edit is not enabled by default right? So this would only be an issue for those who accidentally enabled exp_edit and in that case the warning should be clear enough.

@ghost
Copy link

ghost commented Sep 23, 2018

@girng exp_edit is not enabled by default right? So this would only be an issue for those who accidentally enabled exp_edit and in that case the warning should be clear enough.

yeah, that's true. thank you for looking into this btw, should be sufficient

@akien-mga akien-mga added this to the 3.1 milestone Sep 24, 2018
@akien-mga akien-mga merged commit 28c6837 into godotengine:master Sep 28, 2018
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants