-
-
Notifications
You must be signed in to change notification settings - Fork 19.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added warning when min_value of range <= 0 while exp_edit is true. #22381
Conversation
…t is true. Added warning when min_value of range is smaller than 0 while exp_edit is true. The new warning is: "If exp_edit is true min_value must be > 0."
@dualmatrix i think there is something else going on here. |
@girng I'm just going by the docs which state that the value must be > 0 |
the docs say the |
@girng The bug with value only occurs when min_value is <= 0 and exp_edit is true otherwise it works fine. |
I took a look at the 3.0 code and previously exp_edit was just ignored if min_val <= 0. |
That's what I thought was normal (not a bug)... okay, well a lot of game projects who will move from 3.0.6 to 3.1 will most likely need to adjust this then :P but yeah,i agree, a warning would be best. instead of this |
@girng exp_edit is not enabled by default right? So this would only be an issue for those who accidentally enabled exp_edit and in that case the warning should be clear enough. |
yeah, that's true. thank you for looking into this btw, should be sufficient |
Thanks! |
Added warning when min_value of range is smaller or equal to 0 while exp_edit is true.
The new warning is: "If exp_edit is true min_value must be > 0."
This should make it more clear, see #21923