Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tile selection outline in tileset editor temporarily offsets when creating/deleting a tile #22725

Closed
ghost opened this issue Oct 4, 2018 · 5 comments

Comments

@ghost
Copy link

ghost commented Oct 4, 2018

Godot version:

8068d02

OS/device including version:

Win 7, Intel HD 4000

Issue description:

Was requested to create a new issue on this rather than a comment so here it is.
When you create a single tile and then choose to create another tile notice how the yellow outline of the last created tile offsets to the top right. This happens to all latest created tiles when you choose to create either a single tile or tile atlas or autotile. But there shouldn't be any offset at all. Note that this is temporary and doesn't affect any functionality as far as I know. This behavior as observed when trying to delete a tile and creating a new tile right after.
45668751-96119780-bb3b-11e8-8c8e-f12a3a8d7fb5
45668905-fa345b80-bb3b-11e8-9a77-02fc07d04b81

Steps to reproduce:
1.Create a new tileset and add an image
2. Click on new single tile and draw a tile or perhaps delete any existing tile
3. Click on new single tile again

Minimal reproduction project:

@ghost ghost changed the title Tile selection outline in tileset editor temporarily offsets when creating/deleting a new tile Tile selection outline in tileset editor temporarily offsets when creating/deleting a tile Oct 4, 2018
@capnm
Copy link
Contributor

capnm commented Oct 4, 2018

IMO this is a hack to visualize the boundaries of overlapping tiles, the tile actually requires similar gizmos for the region, as e.g. the collision polygon editor has.

image

image

@akien-mga akien-mga added this to the 3.1 milestone Oct 5, 2018
@capnm
Copy link
Contributor

capnm commented Oct 11, 2018

The offset occurs only when you create a new tile or delete one, I am not sure how that would help with visualization.

IIRC if the new tile were created at the same position as the old tile, you wouldn't see it.
I think you are not able to select a completely covered tile, e.g. to delete it.
The correct solution for this issue would be IMO as I said, to add the resize gizmos.

@capnm
Copy link
Contributor

capnm commented Oct 13, 2018

I'm not talking about use cases, but about editing or creating tiles. It doesn't seem to matter where the new tile placeholder appears, as long as you can understand that you should 'paint it' somewhere now. (Such a creation of new tiles seems to be useless without an enabled grid-snap anyway)

peek12

@capnm
Copy link
Contributor

capnm commented Oct 17, 2018

If I understand it correctly, the tile that appears offsetted is actually an indicator that a tile is waiting to be placed?

At least I think @MarianoGnu did this on purpose. (Maybe it would be better to just change the cursor shape, I don't know)

@MarianoGnu
Copy link
Contributor

MarianoGnu commented Nov 22, 2018

No, it was not intentional, it is a bug. While drawing a tile i have a temp variable storing the rect, this is drawn instead of the actual region, what happens here is that there's no current selection, but the rect is drawn anyway.
The offset is because on the WORKSPACE_MARGIN, wich means i added some extra pixels to allow users to click out of the texture

@ghost ghost closed this as completed Jan 12, 2019
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants