Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_move() asking for 3 arguments with KinematicBody2D. #22829

Closed
SyntaxPartnership opened this issue Oct 7, 2018 · 3 comments · Fixed by #23090
Closed

test_move() asking for 3 arguments with KinematicBody2D. #22829

SyntaxPartnership opened this issue Oct 7, 2018 · 3 comments · Fixed by #23090
Labels
bug topic:physics
Milestone
3.1

Comments

@SyntaxPartnership
Copy link

SyntaxPartnership commented Oct 7, 2018 •
edited
Loading

untitled

I get this error when using test_move() on 3.1.0 alpha. Running on Windows 7, 32bit, GLES2
@KellyThomas
Copy link
Contributor

KellyThomas commented Oct 7, 2018 •
edited
Loading

Here is the documentation note a third paramter infinite_inertia

http://docs.godotengine.org/en/latest/classes/class_kinematicbody2d.html#class-kinematicbody2d-test-move

Though it is unclear what this parameter means for this method.

@DavidSichma
Copy link
Contributor

#16757 added this new parameter to the movement related methods of KinematicBody (2D and 3D). The default values have been set to infinite_inertia = true in the other bindings, but not for this method.

@AndreaCatania Adding DEFVAL(true) should fix it. Or is there a reason why this wasn't added?
Speaking of infinite_inertia, there is an incosistency. The 3D KinematicBody::move_and_slide is the only method with infinite_inertia being the last argument. Could be corrected as well.

DavidSichma added a commit to DavidSichma/godot that referenced this issue Oct 17, 2018
@DavidSichma
Fix inconsistency in KinematicBody
6ec4da2 
- moved new infinite_inertia argument of move_and_slide and
move_and_slide_with_snap in KinematicBody and KinematicBody2D to the
end if not already there. This makes the order of arguments consistent
and should keep projects from 3.0 compatible as this argument did not
exist in 3.0. Docs updated accordingly.
- renamed max_bounces to max_slides for consistency. Docs updated
accordingly.
- the argument infinite_inertia in test_move is now optional, as it is
in every other movement related method. This closes godotengine#22829.
@DavidSichma DavidSichma mentioned this issue Oct 17, 2018
Merged
@nobuyukinyuu
Copy link
Contributor

bump

@groud groud added this to the 3.1 milestone Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:physics
Projects
None yet
Milestone
3.1
Development

Successfully merging a pull request may close this issue.

Consistency in KinematicBody DavidSichma/godot
4 participants
@nobuyukinyuu @KellyThomas @groud @DavidSichma