Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewports do not inherit project default rendering settings #23732

Open
triverske opened this issue Nov 15, 2018 · 6 comments
Open

Viewports do not inherit project default rendering settings #23732

triverske opened this issue Nov 15, 2018 · 6 comments

Comments

@triverske
Copy link

triverske commented Nov 15, 2018

Godot version:
Godot 3.1 Alpha 2

OS/device including version:
Windows 10 64 Bit
NVIDIA GTX 960M
Driver v416.16

Issue description:
Viewports do not inherit project default settings, requiring the user to manually set MSAA, Shadow Atlas, etc

Minimal reproduction project:
GLES3.zip

@mrcdk
Copy link
Contributor

mrcdk commented Nov 15, 2018

You need to set the shadow atlas size in the shadow atlas group of the Viewport

@triverske
Copy link
Author

Odd, I recall messing with the value and it not changing anything, but it appears to work now. I suppose the better question is why does viewport not automatically use the defaults set in the project settings

@triverske triverske changed the title Shadows do not Render when viewed through Viewport Viewports do not inherit project default rendering settings Nov 15, 2018
@Calinou
Copy link
Member

Calinou commented Sep 4, 2019

If viewports are made to inherit project settings by default, how could specific settings be overridden?

@triverske
Copy link
Author

Maybe a specific "override" mode or something of that nature? Or maybe when you create the node it automatically could have the default values in there.

@Calinou
Copy link
Member

Calinou commented Sep 6, 2019

@triverske The issue is that properties are only saved to scene files if they differ from the default (as of Godot 3.1). Therefore, if the project settings are identical to the Viewport's default settings, the property wouldn't be saved to the scene file, which would make the behavior inconsistent with project settings that don't match the Viewport's defaults.

@triverske
Copy link
Author

Perhaps a checkbox then that just says "inherit from project settings" then, that at least will let people know that by default they won't get applied to a newly created viewport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants