New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tree_exited signal callbacks are run in the editor even when the script is not "tool", can cause editor crash #27125
Comments
It also happens if I try to close any scene. So if there is a "corrupted scene", even if I close it, or if I try to close a "healthy scene", Godot crashes |
Cannot confirm on Arch Linux, Godot 3.1 stable 64 bit. Might be nice to have a trace from |
Cannot confirm the above on Ubuntu 18.04 too, but I've got this crash after trying to close some as modified marked scene by selecting "Don't Save" in the "Please Confirm" dialogue. It doesn't seems to be reproducible :-/ Terminal dump:
|
I think I found the trigger for this crash, can you guys test the following @bojidar-bg and @capnm
|
Would be good if someone who can reproduce it can try with a debug build ( |
A reproducible backtrace with your recipe;)
|
The problem is that the directly connected object methods are apparently executed after the scene tab is selected. If you connect something less dangerous, you will just get an "interesting" effect: |
Hmm, I find this kinda strange, these callbacks shouldn't happen in the editor, the Node isn't set to |
Maybe all connections with the Save flag on should be completely disabled in the editor, not just swept under the rug by assuming they are connected to placeholder script instances? |
I have this backtrace when I try to open all scenes at one time:(it can be easily selected when you search .tscn in grid view in filesystem dock and then select and open all)
|
Without an associated script, it is generally not possible to choose whether the signal should be active as tool mode or not. I think this should not be allowed or at least properly documented. (I didn't know that the direct callbacks work, it's actually a surprise to me that Godot 2.1.x has the same issue.) |
I think I reported a similar issue #13394 and #13070 is also related |
Still happens with master
|
I think that godotengine/godot-proposals#214 would also solve this |
Still valid in ba51af7 |
Godot version: 3.1-stable_X11.64
OS/device including version: Solus 3.9999 Gnome Nvidia GTX 1050TI
Issue description:
Randomly when I switch between scenes Godot crashes, the only thing on the terminal when this happens is:
I am using GLES2
Minimal reproduction project:
It's not minimal but can give enough context
mooncheeser source.zip
The text was updated successfully, but these errors were encountered: