Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make .import files hidden #28826

Closed
KoBeWi opened this issue May 11, 2019 · 9 comments
Closed

Make .import files hidden #28826

KoBeWi opened this issue May 11, 2019 · 9 comments

Comments

@KoBeWi
Copy link
Member

KoBeWi commented May 11, 2019

Godot version:
3.1.1

Issue description:
There were complains about .import files, that they clutter the directories and should be moved elsewhere or removed etc. etc. I agree that they are problematic, because e.g. it's harder to browse files. By default they are sorted by name and it results in png/import/png grid in directory view. Ofc you can change sorting to per type and it makes things a lot easier, but you need to do it for each folder (at least on Windows), which is not a perfect solution.

So how about just making the .import files hidden? On Windows it's a file flag, for Linux I guess all import files would need to start with a dot in name. Hiding these files would make the asset directory much more friendly to browse. It of course introduces problems, like since you can't see .import files, you might not be aware that they are here, which might create problems with moving or deleting files from system explorer. However, Godot should handle .imports for files moved/deleted externally and that's another issue. I guess when it's solved, making .import files hidden shouldn't have more downsides.

I've seen this request mentioned in comments, like here or here, but it never got its own issue, so here is one.

@slapin
Copy link
Contributor

slapin commented May 11, 2019

If you hide something which exists it is not normal. It might be fine to have option, but that should not be default. This is developer tool. Also the files are in completely separate directory, why do you go in there if you don't want to?

@slapin
Copy link
Contributor

slapin commented May 11, 2019

Or you ask about files which are created for import parameters? These should not be hidden.

  1. They are part of your project because your settings are kept there. They should be added to your version control too, if you do not want to lose import options.
  2. Thay are not clutter, they are functional files. And you should be aware of their presence and why they are needed. Pretending they do not exist will do you nothing good, they are project data, the same as your asset files.

@KoBeWi
Copy link
Member Author

KoBeWi commented May 11, 2019

Or you ask about files which are created for import parameters?

Yes, these ones. My point is, you are not supposed to edit them manually. You edit all the import settings inside Godot, so these files are totally irrelevant for you. Or that's how it should be. Cool, they exist and are important, but I don't see any reason why it shouldn't be done behind the scenes, so you don't worry how it works. And if you do care to do anything with them (dunno what would you), you can enable visibility for hidden files on your OS if they were hidden.

@Calinou
Copy link
Member

Calinou commented May 11, 2019

I think it's fine to leave them visible too. They contain important metadata which should be checked into version control, and making them hidden by default could mislead people into adding them to their .gitignore.

They can also be edited by hand (which might be useful in some cases), so this possibility should remain clear.

@NathanWarden
Copy link
Contributor

NathanWarden commented May 11, 2019

These files are very important and should be in a place where it's obvious to the developer that they should be checked into version control or backed up. Hidden files/folders typically start with a . and in Godot are automatically generated. It would completely break a project if the developer didn't back up the import meta files and had to recover it on another machine or in another folder.

@KoBeWi
Copy link
Member Author

KoBeWi commented May 11, 2019

It could be at least optional. Although Unix systems with their .naming would be a problem here.

@Calinou
Copy link
Member

Calinou commented May 11, 2019

It could be at least optional.

This poses the issue of making documentation and tutorials more confusing, since .import files could now have two potential names. Moreover, if both file.import and .file.import exist, which one would have priority?

@vnen
Copy link
Member

vnen commented May 12, 2019

Related: #24177

@KoBeWi
Copy link
Member Author

KoBeWi commented Jun 14, 2020

Closing in favor of the proposal (see mention above).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants