Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scene is marked dirty/modified when unrelated resources are modified #45601

Closed
Flavelius opened this issue Jan 31, 2021 · 2 comments · Fixed by #59564
Closed

Scene is marked dirty/modified when unrelated resources are modified #45601

Flavelius opened this issue Jan 31, 2021 · 2 comments · Fixed by #59564

Comments

@Flavelius
Copy link
Contributor

Flavelius commented Jan 31, 2021

Godot version:

3.2.4.beta6.mono.official

OS/device including version:

Win10

Issue description:

Whenever a resource is modified while a scene is open, no matter whether the resource is used in the scene or not, the scene get's marked as modified too.

Steps to reproduce:
Create and open a scene, modify some unrelated resource, notice the asterisk appear in the scene tab.

@Calinou
Copy link
Member

Calinou commented Jan 31, 2021

Since the editor can't be marked dirty (only scenes can), I believe this is done so that you get an "unsaved changes" warning when exiting the editor. Now that #32321 was merged, we need to be especially careful about avoiding false negatives.

@Flavelius
Copy link
Contributor Author

Flavelius commented Jan 31, 2021

If the editor has to keep track of the dirty resources it has to have knowledge of the dirty state somehow in my logic; i see no reason why it couldn't include the asterisk in the application title for it like most other software does. Maybe it's more complicated internally, but as communication to the user it would make it clearer than pretending the scene has been changed when it actually hasn't, just as a workaround. And it could still warn about unsaved changes before exiting unrelated to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants