Warn you before binding a new shortcut if another shortcut is bound to that key

[hazlema]

Godot version

3.3.2.stable

System information

Linux Mint 19.3 Tricia x86_64

Issue description

If you assign a key bind in shortcuts that is already bound this is allowed.
There should be a popup telling you that key is already bound and offer you the option to unbind it or cancel.

Steps to reproduce

Editor : Settings : Shortcuts
Bind a key combination that is already bound.

Minimal reproduction project

No response

[Calinou]

Binding a single key to multiple shortcuts is valid in many scenarios because some shortcuts are only effective if their dock is currently visible or focused. Due to this, I'd display a warning dialog in this case but I wouldn't prevent binding the same key to multiple shortcuts.

Note that the editor shortcut system is being revamped here, so a pull request will likely have to wait for that PR to be merged first.

[EricEzaM]

This is for sure a duplicate, but the issue is that there are different contexts in the editor (at least in 4.0, 3.X does not have this feature). E.g. a shortcut being Ctrl+A in the Scene Tree and another shortcut being the same in the Animation Editor is perfectly fine, as they won't overlap. However the shortcut editor in Editor Settings doesn't know about these contexts so you would potentially get a lot of false positives saying that there is a shortcut conflict when there really isn't.

Note this overall issue should be helped in 4.0 by #42109, which implemented shortcut contexts, so, for example, pressing Ctrl+A in the script editor won't select all text AND open the "New Node" dialog.

[EricEzaM]

Found it #47593