Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport update_mode issue on ViewportContainer ENTER_TREE or VISIBILITY_CHANGED Notification #52786

Open
butkeim opened this issue Sep 17, 2021 · 0 comments

Comments

@butkeim
Copy link
Contributor

butkeim commented Sep 17, 2021

Godot version

3.3.stable

System information

Windows 10

Issue description

If a ViewportContainer is visible_in_tree it will set update_mode to all children Viewports to Viewport::UPDATE_ALWAYS when receiving a NOTIFICATION_ENTER_TREE or NOTIFICATION_VISIBILITY_CHANGED.
This will cause performance issues if you are dealing with a lot of ViewportContainer containing a Viewport (in my case for exemple, in the hundreds causing fps drop and CPU over usage).

Steps to reproduce

  • Create a ViewportContainer
  • Create a sub Viewport (child to the ViewportContainer)
  • Duplicate the ViewportContainer hundreds of time, and see the computational impact (using CPU monitoring f. ex).

Minimal reproduction project

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants