Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect_to_host functions in network classes block on address resolution #53265

Closed
jordo opened this issue Sep 30, 2021 · 1 comment · Fixed by #57649
Closed

connect_to_host functions in network classes block on address resolution #53265

jordo opened this issue Sep 30, 2021 · 1 comment · Fixed by #57649
Labels
enhancement topic:network
Milestone
3.5

Comments

@jordo
Copy link
Contributor

jordo commented Sep 30, 2021 •
edited
Loading

Godot version

3.x, master

System information

all

Issue description

the implementation of connect_to_host in the network classes (other than HttpClient) can end up blocking the main engine thread in getaddrinfo()

Steps to reproduce

Setup a laggy DNS resolver and call connect_to_host from a network peer, or websocket client. The engine main thread will block in getaddrinfo().

Minimal reproduction project

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement topic:network
Projects
None yet
Milestone
3.5
3 participants
@Calinou @jordo @akien-mga