Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 4: script variables in Visual Script are always exported #58158

Closed
archerallstars opened this issue Feb 15, 2022 · 4 comments · Fixed by #60821
Closed

Godot 4: script variables in Visual Script are always exported #58158

archerallstars opened this issue Feb 15, 2022 · 4 comments · Fixed by #60821

Comments

@archerallstars
Copy link

Godot version

v4.0.alpha2.official [79077e6]

System information

Windows 11, Vulkan Clustered, Intel UHD Graphics 620 v30.0.101.1340

Issue description

The script variables in Visual Script are exported by default regardless of the export toggler, as shown in the screen recording below:

2022-02-15.19-13-07.mp4

And there's no way to turn it off due to the issue #58072.

This is a regression from Godot 3.4.

I expect the variable to be exported only when selected.

Steps to reproduce

  1. Create a variable in Visual Script. It will be exported regardless of the export toggler.

Minimal reproduction project

No response

@archerallstars
Copy link
Author

Update: even though the variable always shows in the inspect tab as the exported variable, the users can't change its value in the inspector tab unless they actually exported the variable, as shown in the screen recording below:

2022-02-21.15-20-16.mp4

@Gallilus
Copy link
Contributor

Gallilus commented Apr 2, 2022

I did a check and this issue seems to be there from V4.0a1.
The VisualScriptEditorVariableEdit seems to save the export variable_parameter.

So I assume when converting to GDScript 2.0 there is a change in how the export is handled, and as the export variable_parameter is no longer found the inspector defaults to showing the variable.

@Calinou Do you know the next person to ping to get more guidance?

@Calinou
Copy link
Member

Calinou commented Apr 2, 2022

So I assume when converting to GDScript 2.0 there is a change in how the export is handled, and as the export variable_parameter is no longer found the inspector defaults to showing the variable.

VisualScript does not compile to GDScript behind the scenes. This is probably due to something else.

@Calinou Do you know the next person to ping to get more guidance?

I don't know who else is actively working on visual scripting, sorry. I've never worked on it myself.

@Gallilus
Copy link
Contributor

Gallilus commented Apr 2, 2022

VisualScript does not compile to GDScript behind the scenes. This is probably due to something else.
Indeed.
The problem is that the editor may now interpret "exported" differently than 3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants