Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GDscript editor keeps adding useless '# warning-ignore:return_value_discarded' #61456

Open
DrAlta opened this issue May 27, 2022 · 2 comments
Open

Comments

@DrAlta
Copy link

DrAlta commented May 27, 2022

Godot version

v3.5.rc2.official [5f9bc7e] and v3.4.4.stable.official [419e713]

System information

Ubuntu 21.10

Issue description

I was fixing the warnings and wasing really paying attention to what the [ignore] link was doing and ended up with a dozen copies of "# warning-ignore:return_value_discarded" inserted into my files as it's not detecting them.

Steps to reproduce

Open the attached new_script.gd in the built-in editor. Open the warning panel. Click on the [Ignore] on

"[Ignore]Line 6 (RETURN_VALUE_DISCARDED):The function 'connect()' returns a value, but this value is never used."
or "[Ignore]Line 8 (RETURN_VALUE_DISCARDED):The function 'connect()' returns a value, but this value is never used."

Minimal reproduction project

MRE.zip

@Calinou
Copy link
Member

Calinou commented May 27, 2022

I suppose clicking the Ignore button should remove the line in question from the warnings list automatically, without waiting for the script editor to parse the script again.

@DrAlta
Copy link
Author

DrAlta commented May 27, 2022

I suppose clicking the Ignore button should remove the line in question from the warnings list automatically, without waiting for the script editor to parse the script again.

It does reparse the script and reports it one line later, now that it's added ignore line.

@akien-mga akien-mga added this to the 3.x milestone Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants