Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanoramaSky: PNG looks terrible, HDR stuck on "(re)Importing Assets" #65332

Closed
venilark opened this issue Sep 4, 2022 · 3 comments
Closed

PanoramaSky: PNG looks terrible, HDR stuck on "(re)Importing Assets" #65332

venilark opened this issue Sep 4, 2022 · 3 comments

Comments

@venilark
Copy link

venilark commented Sep 4, 2022

Godot version

Alpha 15

System information

Windows 10

Issue description

Given Godot's lack of Cubemap support, I had to use an online tool to convert a cubemap to an equirectangular image so it can be used with the PanoramaSky. I converted it and to my surprise it looks awful when imported into Godot.

Here is what it looks like when opened in Blender
blender

same in Godot after the conversion
godot

So I converted to HDR using another online tool, it worked and it looked good, but now every time I try to drag it onto the "PanoramaSkyMaterial>Panorama" slot I get this
reimporting

If it is a matter of adjusting some options so the PNG image looks good then that would be fine for me but nothing I tried worked, image always looks terrible.

Steps to reproduce

Try to drag sky-panorama.hdr onto the "PanoramaSkyMaterial>Panorama" slot, as soon as it makes contact with the viewport you'll get the "(re)Importing Assets".

@Calinou
Copy link
Member

Calinou commented Sep 4, 2022

The freeze on importing HDR images is already being tracked in #61948.

As for PNG quality: VRAM compression makes this kind of pattern look quite bad, so I recommend switching the PNG image to use Lossless compression in the import dock. Make sure to do this after the texture is detected to be used in 3D, as Godot will revert it to VRAM Compressed otherwise.

@venilark
Copy link
Author

venilark commented Sep 4, 2022

The freeze on importing HDR images is already being tracked in #61948.

As for PNG quality: VRAM compression makes this kind of pattern look quite bad, so I recommend switching the PNG image to use Lossless compression in the import dock. Make sure to do this after the texture is detected to be used in 3D, as Godot will revert it to VRAM Compressed otherwise.

Thank you now it looks good, I think it shouldn't revert the settings you chose but at least it works.
If I change the Panorama texture at runtime it should keep the latest settings, right? So technically once Godot knows I want that texture to be used for 3D (by doing what you told me in a test scene for example) and to be Lossless it shouldn't modify anything ever again in any scene.

@Calinou
Copy link
Member

Calinou commented Sep 4, 2022

If I change the Panorama texture at runtime it should keep the latest settings, right?

Yes, the Detect 3D flag is only set once per texture.

Note that the panorama you're using is quite large, yet it mostly features low-frequency data. To decrease memory usage and improve loading times, consider resizing it to 4096×2048 or even 2048×1024.

Closing, as the rest of this issue is a duplicate of #61948.

@Calinou Calinou closed this as not planned Won't fix, can't repro, duplicate, stale Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants