Boot Splash scaling is too small on Android, even with Fullsize enabled

[MecoCL]

Godot version

3.5.1 stable

System information

Android 11 (GLES2)

Issue description

It's scaling so small on phone but it's scalling normally on PCs

Steps to reproduce

N/A

Minimal reproduction project

N/A

[Calinou]

Is Fullsize enabled in the splash screen project settings? If not, it's expected that the splash image appears small on Android devices. These devices pretty much always feature displays with higher DPI compared to desktop displays.

[MecoCL]

it is activated and still small on phones

[Calinou]

@MecoCL Please upload a minimal reproduction project to make this easier to troubleshoot.

[Calinou]

@MecoCL The minimal reproduction project didn't upload (likely because you clicked away from the text field while it was still uploading). Try editing your post and upload it again.

[MecoCL]

@Calinou Splash Screen.zip

[DissonantVoid]

Can confirm, this is how it looks on my 20:9aspect-ratio, 720x1600pixels phone

Based on provided reproduction project. Godot 3.5.stable

[MecoCL]

lol, Imagine my phone is 2408×1080 pixels

[akien-mga]

For anyone interested in debugging this further: you can look into places where the application/boot_splash/fullsize setting is used. It seems to be used explicitly to handle scaling but apparently it doesn't work as expected:

• godot/main/main.cpp

  Line 2150 in d759210

  const bool boot_logo_scale = GLOBAL_DEF_BASIC("application/boot_splash/fullsize", true);

• godot/platform/android/export/export_plugin.cpp

  Line 1519 in d759210

  bool scale_splash = GLOBAL_GET("application/boot_splash/fullsize");

[MecoCL]

@akien-mga I wasn't, I just thought you forgot or something.

[Magamex]

Hello everybody!
Has a solution to this problem been found?
I have the same problem...

[ghost]

Doesn't even work properly in 4.0.2 :(

[lawnjelly]

Wild guess at what is happening, as I haven't debugged (it takes days to set up Android debugging 😀 ):

Looking at RasterizerGLES2::set_boot_image():

	int window_w = OS::get_singleton()->get_video_mode(0).width;
	int window_h = OS::get_singleton()->get_video_mode(0).height;

If these are not set properly the following code won't work:

		if (window_w > window_h) {
			//scale horizontally
			screenrect.size.y = window_h;
			screenrect.size.x = imgrect.size.x * window_h / imgrect.size.y;
			screenrect.position.x = (window_w - screenrect.size.x) / 2;

		} else {
			//scale vertically
			screenrect.size.x = window_w;
			screenrect.size.y = imgrect.size.y * window_w / imgrect.size.x;
			screenrect.position.y = (window_h - screenrect.size.y) / 2;
		}

On Android, the default_videomode is only changed from default in OS_Android::set_display_size.

Which is called from Java_org_godotengine_godot_GodotLib_resize. Which would have to be called by public static native void resize(int width, int height); from java. This would have to be called from onSurfaceChanged in java in GodotRenderer.

Maybe the boot screen is getting set before the window width and height have been set.

So I suspect some debugging of onSurfaceChanged() would reveal the problem. Maybe order of construction / operations. Maybe one for @m4gr3d next time he is debugging?

[0-Vanes-0]

The issue still exists in v4.2.1.stable.official [b09f793]

[chriisduran]

Still getting the problem of splash screen, Juancho, before launch a new version of godot please fix this issue