Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scale manipulator does not scale rotated objects uniformly #71675

Closed
CookieBadger opened this issue Jan 19, 2023 · 7 comments · Fixed by #72362
Closed

Scale manipulator does not scale rotated objects uniformly #71675

CookieBadger opened this issue Jan 19, 2023 · 7 comments · Fixed by #72362

Comments

@CookieBadger
Copy link
Contributor

Godot version

4.0beta13

System information

Windows10, AMD Ryzen 9 3900XT, RTX3070, Vulkan

Issue description

I would expect when using the scale tool on an object with a scale of (1,1,1) without touching any of the handles to result in a uniform scale again (i.e. 0.1, 0.1, 0.1) and not one, where all components are different.
However, when the object has been rotated, this is the case no matter if using local or global transform.

RotateAndScaleBroken

This behavior was working properly in 3.x

Steps to reproduce

  • Create an object (e.g. a CSGBox3D)
  • Rotate it a little on different axes
  • Scale it with the scale tool, without using any handle (uniform scale)
  • Observe how the object is now slightly squashed or stretched, i.e. the scale components are not equal anymore

Minimal reproduction project

BrokenScale.zip

Observe how the cube turns into a pillar when using the Scale Manipulator.

@CookieBadger
Copy link
Contributor Author

still valid in beta15
badScaling

@CookieBadger
Copy link
Contributor Author

Started bisecting the issue.
Issue did not appear in 4.0-dev.20211210, started appearing in 4.0-dev.20220105/.

@CookieBadger
Copy link
Contributor Author

CookieBadger commented Jan 29, 2023

After bisecting up until 3 revisions, I am confident, that 6af77c7 introduced the bug.

@clayjohn
Copy link
Member

CC @TokageItLab

@TokageItLab
Copy link
Member

TokageItLab commented Jan 29, 2023

I have already know it is due to #53684. I'll take a look later.

@TokageItLab
Copy link
Member

@ExquisiterEmil Okay, I sent #72362. Please test it if you can.

@CookieBadger
Copy link
Contributor Author

@TokageItLab Works! Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants