Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot 4 "Trim" audio import setting does nothing #75236

Closed
Tracked by #76797
markopolojorgensen opened this issue Mar 22, 2023 · 4 comments · Fixed by #75261
Closed
Tracked by #76797

Godot 4 "Trim" audio import setting does nothing #75236

markopolojorgensen opened this issue Mar 22, 2023 · 4 comments · Fixed by #75261

Comments

@markopolojorgensen
Copy link

Godot version

4.0.1 official release

System information

Windows 10, Forward+, AMD Radeon R9 290X

Issue description

When importing small wav files, the "Trim" setting in the import dock has no effect. I noticed it for the first time on a ported 3.5 project (where Trim did work).

Expected behavior: trimmed audio files lose the silence at the beginning and end of the stream, so when you play them the actual sound part of the file plays immediately.

Not sure if this is only an issue with wav files, I haven't tried other audio formats.
Not sure if it's related to file length, I've only tried short samples.

Steps to reproduce

  1. Create a wav file with some silence at the beginning and then a sound.
  2. Import into a godot 4 project, turn on Trim in import settings for that file.
  3. Play audio stream in Inspector or assign it to an AudioStreamPlayer and play in-game.

Minimal reproduction project

no_trim_issue_project.zip

@AThousandShips
Copy link
Member

AThousandShips commented Mar 23, 2023

Edit: Lots of false starts, it seems the loop mode check is invalid and it previously would trim only when the loop mode was disabled, now it will do it only when not disabled, but only for the detected mode, seems to be a regression

This is present in 3.5 though so not sure how it works differently for you there

@AThousandShips
Copy link
Member

Regression from #59170

@AThousandShips
Copy link
Member

This bug is also present on 3.5

@markopolojorgensen
Copy link
Author

I didn't actually test 3.5, so if you say it's also present there, I believe you. I guess I had imports from an older version that didn't get reimported in 3.5 and so seemed to behave correctly?

@akien-mga akien-mga added this to the 4.1 milestone Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants