Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A warning is triggered by AudioStreamPlayer when using play(seek in position) in an ogg audio track #75762

Closed
Tracked by #76797
conest opened this issue Apr 6, 2023 · 3 comments · Fixed by #80452
Closed
Tracked by #76797

Comments

@conest
Copy link

conest commented Apr 6, 2023

Godot version

4.0.2 stable

System information

Apple M2 Pro; Vulkan API 1.2.231 - Forward+

Issue description

This warning will be triggered when using play(certain position) from an AudioStreamPlayer loaded with ogg file.
The warning was not always occurred, only some certain seeking positions will trigger it.

W 0:00:11:0687   audio.gd:47 @ changeBGM(): Burning negative samples doesn't make sense. Check seek algorithm.
  <C++ Source>   modules/vorbis/audio_stream_ogg_vorbis.cpp:332 @ seek()
  <Stack Trace>  audio.gd:47 @ changeBGM()
                 audio.gd:65 @ _on_button_3_pressed()

Steps to reproduce

By pressing buttons for switching audios in the same position. Some positions will trigger the warning.
Toggle the CheckButton to true, and pressing the buttons will play the audio in a fixed position, which will trigger the warning every time for certain audios.

Minimal reproduction project

Archive.zip

@Calinou
Copy link
Member

Calinou commented Apr 6, 2023

cc @ellenhp

@ellenhp
Copy link
Contributor

ellenhp commented Apr 7, 2023

I talked a bit about this here [1]. I have my hands full with other stuff so I don't anticipate working on this any time soon. If anyone wants to take a shot at it, that would be much appreciated.

[1] #64775 (comment)

@MJacred
Copy link
Contributor

MJacred commented Aug 24, 2023

This seems like a duplicate of #59348 (has same warning plus more).

@akien-mga akien-mga added this to the 4.2 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants