Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang trying to close game window when debugging code #80798

Open
balloonpopper opened this issue Aug 20, 2023 · 3 comments
Open

Hang trying to close game window when debugging code #80798

balloonpopper opened this issue Aug 20, 2023 · 3 comments

Comments

@balloonpopper
Copy link

Godot version

4.2.dev3

System information

Windows 10

Issue description

Run your game with a breakpoint in it
When Godot reaches the breakpoint, the game window stays active instead of swapping to the debugger
If you try to close the game window (using the "X" in the top right corner of the window) the process hangs and needs to be forcefully terminated. This does not happen if you hit "stop" in the debugger

Steps to reproduce

As above

Minimal reproduction project

N/A

@Sauermann
Copy link
Contributor

Using the "X" in the top right corner of the window has the effect, that an event is sent to the process, but since the process is paused at a breakpoint, nothing happens.
So my guess would be that this is intended behavior.

@balloonpopper
Copy link
Author

If it's the intended behavior, then I'd suggest it's wrong. By clicking the button you're informing the operating system you want to close the window - that's the expected behavior in any Windows application. The close window button should force close the window - regardless of the state of the debugger, or failing that, switch focus to the debugger and open a popup with some sort of "please close debugger before closing the application" warning so people know why they can't close the window directly.

I can't think of any Windows application where clicking the close window button doesn't close the window unless it opens a "do you want to save your work first?" window.

@Sauermann Sauermann added bug and removed discussion labels Aug 20, 2023
@jsjtxietian
Copy link
Contributor

jsjtxietian commented Sep 6, 2023

I note that one just can't close the window using the "X" in the top right corner, no matter it hits the breakpoint or not.

To fix this I guess we need a way to communicate the button pressed info back to the godot editor and tell the editor to close the debugger or something like this. Using the "X" should have the same effect as closing the debugger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants