ANDROID_SDK_ROOT is deprecated, use ANDROID_HOME instead

[Mrcubix]

Godot version

all | 6758a7f

System information

Windows 10 21H2

Issue description

Building export templates with scons requires user to define the ANDROID_SDK_ROOT variable, which has been made deprecated long ago, ANDROID_HOME should be used instead.

This will avoid people having to figure out why android isn't considered a valid platform when having a proper setup.

see this section | fallback

They may not check for ANDROID_SDK_ROOT in the future, so it's advised to use this newer variable instead.

Steps to reproduce

N/A

Minimal reproduction project

N/A

[philippesic]

Should just be replacing all instances of ANDROID_SDK_ROOT with ANDROID_HOME if I'm not mistaken.

Will open a pr upon confirmation.

[Calinou]

For reference, ANDROID_HOME used to be read as a fallback until 48efd56.

On the other hand, the Android export plugin already uses ANDROID_HOME:

godot/platform/android/export/export_plugin.cpp

Line 2879 in 6758a7f

OS::get_singleton()->set_environment("ANDROID_HOME", sdk_path); //set and overwrite if required

[Mrcubix]

Note that the Android SDK & the MAUI check tool (used for MAUI and Avalonia) for example, does not require the path to be strictly of the root, they may also check for the presence of an additional folder called android-sdk in the case the specified folder isn't exactly the root of the SDK on Windows.

[duarteroso]

Had some issues building because of just that 👍🏽

godot/platform/android/detect.py

Line 46 in 6758a7f

return os.environ.get("ANDROID_SDK_ROOT", -1)

[Calinou]

Should just be replacing all instances of ANDROID_SDK_ROOT with ANDROID_HOME if I'm not mistaken.

Will open a pr upon confirmation.

Feel free to open a PR for this, but please keep reading ANDROID_SDK_ROOT as a fallback to avoid breaking existing builds (especially on CI).