Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming a folder and pressing enter enters the folder #80940

Closed
mieldepoche opened this issue Aug 23, 2023 · 1 comment · Fixed by #81007
Closed

renaming a folder and pressing enter enters the folder #80940

mieldepoche opened this issue Aug 23, 2023 · 1 comment · Fixed by #81007

Comments

@mieldepoche
Copy link
Contributor

Godot version

4.1.1

System information

linux

Issue description

simplescreenrecorder-2023-08-23_19.45.00.webm

as you can see, renaming a folder and then pressing the enter key to confirm both confirms and navigate inside the folder..

Steps to reproduce

  1. FileSystem in split mode
  2. rename a folder in the bottom view and confirm by pressing enter

Minimal reproduction project

any

@coumcashier
Copy link
Contributor

coumcashier commented Aug 24, 2023

Hi mieldepoche

My test show that the file list cd into the folder even if we don't type key::ENTER.
Merely clicking outside the lineEdit will rename and cd into the folder

I think this is because we update the current_path after the rename operation.

EditorNode::get_singleton()->set_current_tab(current_tab);
print_verbose("FileSystem: calling rescan.");
_rescan();
print_verbose("FileSystem: saving moved scenes.");
_save_scenes_after_move(file_renames);
current_path = new_path;
current_path_line_edit->set_text(current_path);
}

the rescan triggers FileSystemList to update eventually

EditorFileSystem::get_singleton()->connect("filesystem_changed", callable_mp(this, &FileSystemDock::_fs_changed));

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants