Foreign nodes are no longer highlighted

[KoBeWi]

Godot version

4.2 6da4ad1

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 30.0.15.1403) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

In 4.2 dev3:

Steps to reproduce

1. Create a scene with some children
2. Instantiate it in another scene
3. Enable editable children

Minimal reproduction project

N/A

[Calinou]

I can't get the color to show up in 4.2.dev3 (Test has editable children enabled):

The yellow color shows up on Sprite2D if I add another node as child while editable children is enabled. It's gone once I restart the editor though.

[bitsawer]

Duplicate of #78577 and #78648

Bisected regression to #72277 by capnm: #78648 (comment)

[KoBeWi]

Is it really? I can consistently reproduce it on master and it consistently works in dev3.

[bitsawer]

I'm not actually sure if we talk about the same thing, by highlight do you mean the color highlight is missing (like Calinou mentioned they yellow color) or something else? Might need some more testing.

[KoBeWi]

Ok it's not related to inherited nodes. It's some Tree bug. TreeItem text can't be colored.
EDIT: At least in SceneTreeEditor.

[KoBeWi]

Caused by this line

godot/editor/gui/scene_tree_editor.cpp

Line 664 in 6da4ad1

p_parent->clear_custom_color(0);

It has existed since 2 months, so something recently might've made it execute more often (aka always).