Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looped animation shows first frame if last one is selected. #85068

Closed
vyshliy opened this issue Nov 18, 2023 · 3 comments · Fixed by #85193
Closed

Looped animation shows first frame if last one is selected. #85068

vyshliy opened this issue Nov 18, 2023 · 3 comments · Fixed by #85193

Comments

@vyshliy
Copy link

vyshliy commented Nov 18, 2023

Godot version

4.2 rc1

System information

ubuntu 22.04

Issue description

Looped animation in animation editor shows first frame if last one is selected. Selected last frame in the timeline is not relevant to its time and visually you don't know how last frame looks.

Peek.2023-11-18.18-00.mp4

Steps to reproduce

  • Make looped animation.
  • Add frame in the end of the timeline.
  • Select last frame.

Minimal reproduction project

N/A

@TokageItLab
Copy link
Member

TokageItLab commented Nov 19, 2023

The end of the loop has two modes: trimming and replacing the first key.

スクリーンショット 2023-11-19 17 48 02

Trimming mode should not cause this problem, so perhaps we should enforce trimming mode when seeking for editor only.

@vyshliy
Copy link
Author

vyshliy commented Nov 19, 2023

I didn't notice any difference when switching to clamp.

Peek.2023-11-19.10-22.mp4

And a little off topic. Apparently the wrap mod only has an effect on looped animation. It might be worth making it inactive, like curves icon, for example, to make it clear when it makes sense to use it.

@TokageItLab
Copy link
Member

TokageItLab commented Nov 19, 2023

Indeed, it did not matter sorry. So corrected, this should not be a problem except in loop mode.

However, if we solve this in the editor only, the problem may be that there will be difference results between playbacking and seeking in the editor. Well, at least I think we can add a hack to revert to the seek results as of Godot 4.1 for editor only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants