Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seeking bug in AnimationPlayerEditor #85193

Merged
merged 1 commit into from Nov 22, 2023

Conversation

TokageItLab
Copy link
Member

@TokageItLab TokageItLab commented Nov 21, 2023

Since seek_delta() has gone, this kind of calculation should be no longer needed. (It is my bad, sorry for wrong porting)


Since the loop is processed when actually seeking to the end, an epsilon value is subtracted on the editor so that it does not seek to the end; Floats cannot detect this epsilon value, so it should not affect the behavior of the editor.

@TokageItLab TokageItLab added this to the 4.2 milestone Nov 21, 2023
@TokageItLab TokageItLab requested a review from a team November 21, 2023 21:51
@TokageItLab TokageItLab modified the milestones: 4.2, 4.3 Nov 21, 2023
@TokageItLab TokageItLab added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 21, 2023
@SaracenOne SaracenOne self-assigned this Nov 22, 2023
Copy link
Member

@SaracenOne SaracenOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, seems to address the issues and the implementation seems fine. LGTM 👍

@akien-mga akien-mga modified the milestones: 4.3, 4.2 Nov 22, 2023
@akien-mga akien-mga removed the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Nov 22, 2023
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's editor code only, looks relatively safe to include now for 4.2-rc2, thus fixing the reported regressions.

@akien-mga akien-mga merged commit ca24529 into godotengine:master Nov 22, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment