Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MacOS] Defining Wine Executable but not rcedit causes infinite instances of Wine to start #89828

Open
ztc0611 opened this issue Mar 23, 2024 · 2 comments

Comments

@ztc0611
Copy link
Contributor

ztc0611 commented Mar 23, 2024

Tested versions

  • 4.2.1

System information

MacOS 14.4

Issue description

I quickly deleted the path to rcedit because I was annoyed with how it opens an instance of the windows game on exit, and the next time I tried to export new instances of wine just kept opening forever until I killed them all in a batch in Activity Monitor. Godot froze and never recovered.
image

Steps to reproduce

Define a wine directory in Editor Settings for Windows exports, then try to export for windows on macOS.

Minimal reproduction project (MRP)

Should happen with any.

@akien-mga
Copy link
Member

This should be a relatively easy issue to tackle for new contributors. The relevant code is in platform/windows/export/export_plugin.cpp, and most likely it needs to check that both Wine and Rcedit are configured before attempting to use either.

@bruvzg
Copy link
Member

bruvzg commented Mar 25, 2024

I can't reproduce it. And that's a really strange behavior, without rcedit path it should fall back to default value (relative rcedit without path) and run wine once. It will work if rcedit is in the wine PATH or result Could not start rcedit executable. error. But nothing should attempt to run wine multiple times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants