Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fog is weird in double precision #91066

Open
fire opened this issue Apr 23, 2024 · 4 comments
Open

Fog is weird in double precision #91066

fire opened this issue Apr 23, 2024 · 4 comments

Comments

@fire
Copy link
Member

fire commented Apr 23, 2024

Tested versions

Untested versions but suspicious

https://github.com/godotengine/godot/releases/tag/4.2.2-stable (double)

System information

Windows 11, Nvidia 3090, Vulkan forward+

Issue description

https://youtu.be/cNQ9ksd5cAw

Fog seems to be not working correctly. Seems to be split into layers instead of being even.

Steps to reproduce

Turning on fog causes this to happen on V-Sekai/godot-crappy-contraptions@0fff44f

Minimal reproduction project (MRP)

godot-crappy-contraptions-main.zip

@fire fire changed the title Fog is weird in my build Fog is weird in double precision Apr 23, 2024
@clayjohn
Copy link
Member

Just looking at that repo briefly, I wouldn't be surprised if V-Sekai@5f5bc2d was the culprit

@fire
Copy link
Member Author

fire commented Apr 23, 2024

I'll take a look

@fire
Copy link
Member Author

fire commented Apr 23, 2024

Unmerging that pr seemed to have no effect. What made the fog work was precision=single.

@Calinou
Copy link
Member

Calinou commented Apr 24, 2024

I can't reproduce this on 4.3.dev b091162 (Linux, GeForce RTX 4090 with NVIDIA 550.67). I tested both Forward+ and Mobile, both give out the same appearance regardless of whether I'm using a single-precision or double-precision build.

Minimal reproduction project: test_fog.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants