Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tileset custom data shows as index (not name) in select mode #92149

Closed
JUSTCAMH opened this issue May 20, 2024 · 3 comments · Fixed by #92322
Closed

Tileset custom data shows as index (not name) in select mode #92149

JUSTCAMH opened this issue May 20, 2024 · 3 comments · Fixed by #92322

Comments

@JUSTCAMH
Copy link

JUSTCAMH commented May 20, 2024

Tested versions

  • Reproducible in v4.3.dev6

System information

Godot v4.3.dev6 - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce RTX 3070 (NVIDIA; 31.0.15.3619) - 11th Gen Intel(R) Core(TM) i7-11700K @ 3.60GHz (16 Threads)

Issue description

In the tileset menu, when setting custom data from the select tab, custom data shows as an index, rather than the name of that data element:
image

Custom data is correctly shown by name when in the paint tab:
image

I believe this is a regression from 4.2, where custom data layers were always shown by name. I'd imagine that with more custom data layers it may be difficult to tell which is which from the select tab.

Steps to reproduce

  • Create a tileset
  • Give the tileset a custom data layer, name it something meaningful
  • Open the select tab and unfold the custom data dropdown
  • The label for the data shows the index rather than the name you set for the custom data
  • In the paint tab, the data is correctly labelled with your custom data name

Minimal reproduction project (MRP)

N/A

@akien-mga
Copy link
Member

CC @groud @KoBeWi

@KoBeWi
Copy link
Member

KoBeWi commented May 20, 2024

It's not a regression.

EDIT:
Nevermind, it is a regression, but also exists in 4.2.2. Might be related to whatever caused #91926, because I see that bug too.

EDIT:
Nevermind², I tested 4.2 again and the issue exists in there.

@KoBeWi KoBeWi removed the regression label May 21, 2024
@KoBeWi KoBeWi removed this from the 4.3 milestone May 21, 2024
@KoBeWi KoBeWi changed the title Tileset custom data shows as index (not name) in select mode (4.3) Tileset custom data shows as index (not name) in select mode May 21, 2024
@groud
Copy link
Member

groud commented May 24, 2024

This is not a regression, there was already a PR opened for that feature in 2022: #66853. I think the PR was good enough, but it modified PropertyInfo, which is pretty core.

Anyway, I've opened #92322 to close this, it modifies the editor only.

@akien-mga akien-mga added this to the 4.3 milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants