Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Game window loses focus due to scene group update #94563

Closed
KoBeWi opened this issue Jul 20, 2024 · 4 comments · Fixed by #94594 · May be fixed by #90034
Closed

Game window loses focus due to scene group update #94563

KoBeWi opened this issue Jul 20, 2024 · 4 comments · Fixed by #94594 · May be fixed by #90034

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Jul 20, 2024

Tested versions

4.3 beta3

System information

Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1060 (NVIDIA; 31.0.15.4633) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

Regression from #89739, though I didn't notice it until recently. Might be a combination of various factors.

When you launch the project, all scenes are saved, which triggers update of scene groups, which causes editor progress to appear due to groups. The editor progress makes the window focused, stealing focus from the launched project.

Steps to reproduce

  1. Make sure run/auto_save/save_before_running is enabled
  2. Open multiple scenes
  3. Run the project
  4. See that the running window is not focused

Minimal reproduction project (MRP)

N/A

@akien-mga
Copy link
Member

Regression from #89739

IIRC there were optimizations to how long it takes to scan scenes for groups. Maybe that progress bar isn't needed anymore?

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 20, 2024

It's still needed, but we could raise the threshold (#90784) to e.g. 20.

@Maran23
Copy link
Contributor

Maran23 commented Jul 21, 2024

I wonder why the project is not focused as it is started AFTER all the saving was done, isn't it?

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 21, 2024

If the project is big enough, there is a delay between saving and doing a filesystem scan (or more like, it takes a while to finish it fully). Scene group update happens at the end of scan, so if gets delayed, it can happen after starting the project. I was not able to reproduce it in a simple project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants