[3.2] [HTML5] Optional GDNative Support #44170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Working, with emscripten > 2.0.9 Yes, the unreleased version. 2.0.9 works, but throws and error due to a bug in emscripten with the thirdparty ENet library. The issue is fixed upstream so newer releases will work.
This "breaks" our loading bar logic (libraries are not counted). Fixing it is non trivial and probably deserves investigating a different strategy.
Available types: - Regular - GDNative (support dynamic linking and thus GDNative WASM files) - Threads (uses WebAssembly Threads)
This is suboptimal as it requires adding an extra flag, but rewriting how feature tags work is beyond the scope of this work.
akien-mga
approved these changes
Dec 7, 2020
|
Thanks! 🎉 |
|
@Faless Is it possible for you to make a PR of your cpp bindings to add HTML support to it? It could benefit those that want to use those bindings for HTML. |
|
@SIsilicon sure, thanks for the reminder, I had totally forgotten. PRed here: godotengine/godot-cpp#530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.2version of #44076 .As mentioned, the GDNative variant requires emscripten
2.0.10+, I'll update the build containers to install both versions and use the correct one for GDNative (this will mean no gdnative with C# on HTML5 until mono can be built with a new emscripten version).