Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.x] [HTML5] Fix build for recent emscripten versions. #48320

Merged
merged 1 commit into from Apr 30, 2021
Merged

[3.x] [HTML5] Fix build for recent emscripten versions. #48320

merged 1 commit into from Apr 30, 2021

Conversation

Faless
Copy link
Collaborator

@Faless Faless commented Apr 30, 2021 •
edited

Library suffix should be .a, the EXTRA_ in
EXTRA_EXPORTED_RUNTIME_METHODS is deprecated.

3.x version of #48319

@Faless
[HTML5] Fix build for recent emscripten versions.
b0f6dec 
Library suffix should be `.a`, the `EXTRA_` in
`EXTRA_EXPORTED_RUNTIME_METHODS` is deprecated.
@Faless Faless added this to the 3.4 milestone Apr 30, 2021
@Faless Faless requested a review from a team as a code owner April 30, 2021 06:06
@akien-mga akien-mga merged commit 859946d into godotengine:3.x Apr 30, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.3.1.

@2shady4u
Copy link
Contributor

Does this fix the issue with godot-cpp plugins compiled using Emscripten version 2.0.17+?

@2shady4u 2shady4u mentioned this pull request May 10, 2021
Open
@Faless Faless mentioned this pull request Jul 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug platform:web topic:buildsystem
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Faless @akien-mga @2shady4u