[3.x] Add more OpenGL Attributes #54751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Johann Meyer <25986904+johannmeyer@users.noreply.github.com> Co-Authored-By: Clay John <claynjohn@gmail.com>
clayjohn
approved these changes
Nov 8, 2021
|
Does this address godotengine/godot-proposals#3465? |
|
No, this exposes two built in attributes that OpenGL provides. The proposal above is about defining your own attributes. I will be creating a 4.x version of this PR tonight. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: Johann Meyer 25986904+johannmeyer@users.noreply.github.com
Co-Authored-By: Clay John claynjohn@gmail.com
Adds GL_VertexID to Spatial and CanvasItem shaders and adds GL_InstanceID to canvas item.
Thanks to Johann Meyer and Clay John for making adding this easy
#19473 (comment)