Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix incompatible addition in auto exposure shader #55983

Merged
merged 1 commit into from Dec 16, 2021

Conversation

timothyqiu
Copy link
Member

After turning on auto exposure on my Android device, it produces a shader compilation error:

E 0:00:02.057   _display_error_with_code: ExposureShaderGLES3: Fragment Program Compilation Failed:
ERROR: 0:38: '+' :  wrong operand types  no operation '+' exists that takes a left-hand operand of type '2-component vector of float' and a right operand of type 'const 2-component vector of int' (or there is no acceptable conversion)
ERROR: 1 compilation errors.  No code generated.

It complains about gl_FragCoord.xy + ivec2(1) operands being incompatible, and auto exposure fails to work even if I change framebuffer allocation type to 3D.

@akien-mga akien-mga merged commit 3f137fb into godotengine:3.x Dec 16, 2021
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the auto-exposure-ivec2 branch December 16, 2021 10:20
@akien-mga
Copy link
Member

Cherry-picked for 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants