[3.x] Fix relative keystore paths on android exporter with custom build #56676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please remember to squash the commits when it's ready for merge. |
jasonwinterpixel
force-pushed
the
3.x-android-keystore-paths
branch
from
788af9e
to
3907029
Compare
|
Okay, will do. Squashed. |
akien-mga
approved these changes
Jan 12, 2022
|
Thanks! |
|
Cherry-picked for 3.4.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #56673
If you use a relative path for the release and debug keystores in an Android exporter with 'custom build' enabled, godot will pass those relative paths to gradlew, which interprets them as being relative to res://android/build, but godot's export window itself thinks those paths are relative to res://. This means godot's UI will say you cannot export, but if you run godot --export, it will actually succeed, OR godot will think the paths are correct, but then gradle will fail to find the keystores.
This pull request converts relative paths to absolute paths before sending them to gradlew.