[3.x] Fix touch events when using smartphone AR with WebXR #56819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah, looks like my local 3.x branch was out-of-date. I'll rebase, test and force push in a little bit. |
dsnopek
force-pushed
the
webxr-ar-touch-events-squashed
branch
2 times, most recently
from
a087247
to
aadb1be
Compare
dsnopek
force-pushed
the
webxr-ar-touch-events-squashed
branch
from
aadb1be
to
e39f628
Compare
akien-mga
approved these changes
Jan 17, 2022
|
Thanks! |
dsnopek
added a commit
to dsnopek/godot
that referenced
this pull request
Oct 7, 2022
dsnopek
added a commit
to dsnopek/godot
that referenced
this pull request
Oct 27, 2022
dsnopek
added a commit
to dsnopek/godot
that referenced
this pull request
Nov 10, 2022
dsnopek
added a commit
to dsnopek/godot
that referenced
this pull request
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #55869,
Control's on aCanvasLayerwill actually be shown on the screen when using smartphone AR. However, theControls don't recognize any screen touch or drag events.This PR will generate
InputEventScreenTouchandInputEventScreenDragevents when using smartphone AR, so theControls will actually work!To implement this, I needed to use a piece of information from WebXR (XRInputSource.targetRayMode) that I think would also be useful for game developers, so this also adds a new method to the API:
WebXRInterface.get_controller_target_ray_mode()Discussed briefly on RocketChat with @akien-mga that this could be done only for 3.x for now, until we're actually able to test WebXR on 4.x.