Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix import hints breaking node paths in animations #56956

Merged

Conversation

rburing
Copy link
Member

@rburing rburing commented Jan 19, 2022

Backport #43044. Since I originally made that PR before 3.x and master diverged in this area this was easy for me to do.

@rburing rburing requested a review from a team as a code owner January 19, 2022 15:30
@rburing rburing force-pushed the fix_import_hints_breaking_animations_3.x branch from b1ae47f to 742c54d Compare January 19, 2022 15:43
@akien-mga akien-mga added this to the 3.5 milestone Jan 19, 2022
@rburing
Copy link
Member Author

rburing commented Jan 20, 2022

Just to clarify: this PR adds exactly the same code as in the master version #43044, up to minor syntax changes (comparison to an empty String and iteration over a List now both using the old syntax). Indeed, this can be observed by scrolling through both diffs. The only real difference is where the code is added, namely in _fix_node (which is the only possible place in 3.x), whereas it was _pre_fix_node in master. The same test cases from #38809 and #38163 can be used to test the bugfix (open the project, observe the animation not working, reimport the model, observe the animation working).

@akien-mga akien-mga merged commit 45b8cc4 into godotengine:3.x Jan 21, 2022
@akien-mga
Copy link
Member

Thanks!

@rburing rburing deleted the fix_import_hints_breaking_animations_3.x branch January 21, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants