[3.x] GDScript: Don't coerce default values to the export hint type #58686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vnen
force-pushed
the
gdscript-warn-export-type-mismatch
branch
from
00f7a4b
to
5734a3f
Compare
This behavior is inconsistent with non tools builds and can create issues. Instead, a warning is emitted if there's a type mismatch. If the type can't be converted, an error is shown instead. For the editor it gives a converted value to avoid issues with the property editor, which expects the correct type.
vnen
force-pushed
the
gdscript-warn-export-type-mismatch
branch
from
5734a3f
to
f2166ba
Compare
akien-mga
approved these changes
Mar 10, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This behavior is inconsistent with non tools builds and can create issues. Instead, a warning is emitted if there's a type mismatch. If the type can't be converted, an error is shown instead.
For the editor it gives a converted value to avoid issues with the property editor, which expects the correct type.
Fix #39215