Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix wrong collision reported on move_and_collide #59439

Conversation

fabriceci
Copy link
Contributor

3.x version of #59438

@KoBeWi
Copy link
Member

KoBeWi commented Mar 24, 2022

Checked with my project and it fixes both issues I reported.

@akien-mga akien-mga merged commit 841d6e7 into godotengine:3.x Apr 28, 2022
@akien-mga
Copy link
Member

Thanks!

@jitspoe
Copy link
Contributor

jitspoe commented Aug 25, 2022

So this completely breaks my character movement (finally synced to latest 3.x for the first time this year). I'm not sure if there are other custom engine changes I've made that cause this to behave differently, different data settings, or what, but the long and short of it is that move_and_collide() is not returning anything, so my character is perpetually "falling" when on the ground, building up velocity until I guess it moves far enough in 1 frame to get past the margin?, then repeats.

I'll have to try making a simpler repro case with a vanilla 3.x, but in the mean time, I've had to comment out the && col.collision_safe_fraction < 1

@jitspoe
Copy link
Contributor

jitspoe commented Aug 25, 2022

Yeah, this is a game breaking issue in vanilla Godot 3.5. I see there's already a bug for this here: #62153 I'll post more info there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants