[3.x] Fix get_data() for GradientTexture2D
#61591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-forge
changed the title
get_data() for GradientTexture2Dget_data() for GradientTexture2D
akien-mga
approved these changes
Jun 1, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
GradientTexture2D.get_data()always returning null.The rename of
Texture.get_data()toget_image()(#47435) was lost in the process of backporting GradientTexture2D. The function was there, but it was using the 4.0 name instead of the 3.x name and simply renaming the function fixes the issue entirely.As a workaround, this can be used in place of
get_data()until this PR is merged. I'm using this workaround in my own project.