Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable HDR warning for Viewport on GLES2 projects #65063

Merged
merged 1 commit into from Aug 30, 2022
Merged

Disable HDR warning for Viewport on GLES2 projects #65063

merged 1 commit into from Aug 30, 2022

Conversation

Atlinx
Copy link
Contributor

@Atlinx Atlinx commented Aug 29, 2022

Fixes #65033

@Atlinx Atlinx requested a review from a team as a code owner August 29, 2022 23:16
@YeldhamDev YeldhamDev added this to the 3.x milestone Aug 30, 2022
@YeldhamDev YeldhamDev linked an issue Aug 30, 2022 that may be closed by this pull request
GLES2 Viewport in 2D mode with enabled HDR shows warning but HDR can't be disabled through the inspector #65033
Closed
clayjohn
clayjohn approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@akien-mga akien-mga merged commit c551a79 into godotengine:3.x Aug 30, 2022
@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 30, 2022
@akien-mga akien-mga modified the milestones: 3.x, 3.6 Aug 30, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Aug 30, 2022
Closed
@akien-mga
Copy link
Member

Cherry-picked for 3.5.1.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 30, 2022
@oeleo1 oeleo1 mentioned this pull request Sep 6, 2022
Closed
@Atlinx Atlinx deleted the fix/65033_fix-hdr-warning branch February 18, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clayjohn clayjohn clayjohn approved these changes

Assignees
No one assigned
Labels
bug topic:editor topic:rendering
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

GLES2 Viewport in 2D mode with enabled HDR shows warning but HDR can't be disabled through the inspector
4 participants
@Atlinx @akien-mga @clayjohn @YeldhamDev