Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Don't store frame of playing AnimatedSprite #66155

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 20, 2022

Backport of #65720

Instead of disabling the property, it's being hidden:
godot windows tools 64_nsHM8GZEV6
Alternatively we could still show it, but just don't store the value. But maybe that would be confusing, idk.

@KoBeWi KoBeWi added this to the 3.x milestone Sep 20, 2022
@KoBeWi KoBeWi requested review from a team as code owners September 20, 2022 10:51
@KoBeWi KoBeWi changed the title Don't store frame of playing AnimatedSprite [3.x] Don't store frame of playing AnimatedSprite Sep 20, 2022
@akien-mga
Copy link
Member

Alternatively we could still show it, but just don't store the value. But maybe that would be confusing, idk.

I think that's better, so you still see it go from frame to frame while playing.

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 20, 2022

Ok changed.

@jue131
Copy link

jue131 commented Oct 3, 2022

it's so annoying when you use git, the frame property gets saved in an unchanged scene when you launch it and it often causes merge conflicts, don't understand why only very few people are bothered of this behaviour

@akien-mga akien-mga modified the milestones: 3.x, 3.6 Oct 3, 2022
@akien-mga akien-mga merged commit 90f6baf into godotengine:3.x Oct 3, 2022
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the animat3d_diff branch October 3, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants