New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix avoidance calculation on NO_THREADS build #66806
Merged
akien-mga
merged 1 commit into
godotengine:3.x
from
smix8:navigation_avoidance_nothread_3.x
Oct 3, 2022
Merged
Fix avoidance calculation on NO_THREADS build #66806
akien-mga
merged 1 commit into
godotengine:3.x
from
smix8:navigation_avoidance_nothread_3.x
Oct 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smix8
force-pushed
the
navigation_avoidance_nothread_3.x
branch
from
October 3, 2022 10:40
afa0652
to
47e6fbd
Compare
akien-mga
reviewed
Oct 3, 2022
akien-mga
approved these changes
Oct 3, 2022
akien-mga
added
bug
topic:buildsystem
topic:navigation
cherrypick:3.5
Considered for cherry-picking into a future 3.5.x release
labels
Oct 3, 2022
Might be worth adding a comment in the documentation too, e.g.: diff --git a/doc/classes/NavigationAgent.xml b/doc/classes/NavigationAgent.xml
index 5f8eed4619..e4b0f55dbd 100644
--- a/doc/classes/NavigationAgent.xml
+++ b/doc/classes/NavigationAgent.xml
@@ -6,6 +6,7 @@
<description>
3D agent that is used in navigation to reach a location while avoiding static and dynamic obstacles. The dynamic obstacles are avoided using RVO (Reciprocal Velocity Obstacles) collision avoidance. The agent needs navigation data to work correctly. By default this node will register to the default [World] navigation map. If this node is a child of a [Navigation] node it will register to the navigation map of the navigation node or the function [method set_navigation] can be used to set the navigation node directly. [NavigationAgent] is physics safe.
[b]Note:[/b] After [method set_target_location] is used it is required to use the [method get_next_location] function once every physics frame to update the internal path logic of the NavigationAgent. The returned vector position from this function should be used as the next movement position for the agent's parent Node.
+ [b]Note:[/b] By default, the expensive calculations for avoidance are done in a thread. In HTML5 exports without thread support, they will be done on the main thread, which can lead to performance issues.
</description>
<tutorials>
</tutorials> (I don't know if it's the best place for it, and it should be replicated in 2D if it is.) |
It is 2D and 3D so if added to the docs should be added for both. EDIT |
smix8
force-pushed
the
navigation_avoidance_nothread_3.x
branch
from
October 3, 2022 11:40
47e6fbd
to
f15cb16
Compare
akien-mga
approved these changes
Oct 3, 2022
Thanks! |
Cherry-picked for 3.5.2 |
timothyqiu
removed
the
cherrypick:3.5
Considered for cherry-picking into a future 3.5.x release
label
Dec 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66793
Adds fallback for avoidance calculation on NO_THREADS builds e.g. HTML5 with no threads enabled.