Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Include the follow-viewport-transform into CanvasLayer transform calculations #70310

Merged

Conversation

Sauermann
Copy link
Contributor

The follow-viewport-transform was missing from several calculations

fix #35965 for 3.x
3.x version of #59682

A dedicated backport was necessary, because of merge conflicts

…ulations

The follow-viewport-transform was missing from several calculations

3.x version of godotengine#59682
@akien-mga akien-mga merged commit 3b7bb81 into godotengine:3.x Dec 22, 2022
@akien-mga
Copy link
Member

Thanks!

@Sauermann Sauermann deleted the 3x-fix-follow-viewport-transform branch December 22, 2022 07:58
@kleonc
Copy link
Member

kleonc commented Jan 26, 2023

@akien-mga I guess there's nothing against backporting this to 3.5? 🤔 Follow viewport is still buggy in there.

@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Jan 26, 2023
@akien-mga
Copy link
Member

Sure. Might have to wait for 3.5.3 unless you're very confident in it, as I intend to release 3.5.2-stable soon now that it's had 2 RCs without regressions reported.

@kleonc
Copy link
Member

kleonc commented Jan 26, 2023

Sure. Might have to wait for 3.5.3 unless you're very confident in it, as I intend to release 3.5.2-stable soon now that it's had 2 RCs without regressions reported.

I'm confident about the correctness of this PR. If anything, I think backporting this could break someone's code only in case they'd be manually incorporating the relevant transform as a workaround for the previous buggy behavior. But if breaking the workarounds by fixing the original bug is fine, then I see no reason to postpone it to 3.5.3, can be done in 3.5.2 as well.

For reference just saw someone still having a problem with this: https://www.reddit.com/r/godot/comments/10ly7dz/get_global_mouse_position_not_accurate_when/.

@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants