Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Fix shadows when using 2 directional lights #74539

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

Ansraer
Copy link
Contributor

@Ansraer Ansraer commented Mar 7, 2023

Currently, the viewport for the second light's shadows is calculated incorrectly, and thus no shadows are drawn during the shadow pass.

Fixes #74299


This PR was sponsored by Ramatak with 馃挌

Copy link
Member

@clayjohn clayjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great work!

@lawnjelly lawnjelly merged commit 1a4ef34 into godotengine:3.x Mar 11, 2023
@lawnjelly
Copy link
Member

Thanks!

@Ansraer Ansraer deleted the 3.x-fix-shadows branch March 11, 2023 11:40
@akien-mga akien-mga added the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Apr 12, 2023
@akien-mga
Copy link
Member

Cherry-picked for 3.5.3.

@akien-mga akien-mga removed the cherrypick:3.5 Considered for cherry-picking into a future 3.5.x release label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants