Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] RichTextLabel: Cache text property when toggling BBCode #77403

Merged
merged 1 commit into from Jun 7, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented May 23, 2023

Closes #75899

This little hack prevents the text from disappearing when you accidentally toggle bbcode or you have text saved in scene, but bbcode is enabled (idk if it's possible, the issue suggests that it might happen when you are upgrading). The text will be stored until you reload the scene, so you can disable bbcode and copy it. It does not affect bbcode_text property.

@KoBeWi KoBeWi added this to the 3.6 milestone May 23, 2023
@KoBeWi KoBeWi requested a review from a team as a code owner May 23, 2023 17:09
@akien-mga akien-mga changed the title Cache text property when toggling BBCode [3.x] Cache text property when toggling BBCode Jun 7, 2023
@akien-mga akien-mga merged commit 450902a into godotengine:3.x Jun 7, 2023
13 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the RichHackLabel branch June 7, 2023 12:50
@akien-mga akien-mga changed the title [3.x] Cache text property when toggling BBCode [3.x] RichTextLabel: Cache text property when toggling BBCode Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants